Re: [RFC] btf: Some structs are doubled because of struct ring_buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2019 at 02:05:31PM -0500, Steven Rostedt wrote:

SNIP

>  	struct trace_array *tr = filp->private_data;
> -	struct ring_buffer *buffer = tr->trace_buffer.buffer;
> +	struct trace_buffer *buffer = tr->trace_buffer.buffer;
>  	unsigned long val;
>  	int ret;
>  
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index 63bf60f79398..308fcd673102 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -178,7 +178,7 @@ struct trace_option_dentry;
>  
>  struct trace_buffer {
>  	struct trace_array		*tr;
> -	struct ring_buffer		*buffer;
> +	struct trace_buffer		*buffer;

perf change is fine, but 'trace_buffer' won't work because
we already have 'struct trace_buffer' defined in here

maybe we could change this name to trace_buffer_array?

thanks,
jirka




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux