On Thu, Jul 4, 2024 at 1:56 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> On Thu, 2024-07-04 at 16:16 +0100, Alan Maguire wrote:
>
> [...]
>
> > Nit: would it be worth dropping a debug logging message here
> >
> >
> > /* Skeleton is created with earlier version of bpftool
> > * which does not support auto-attachment
> > */
> > - if (s->map_skel_sz < sizeof(struct bpf_map_skeleton))
> > + if (s->map_skel_sz < sizeof(struct bpf_map_skeleton)) {
> > + pr_debug("libbpf version mismatch, cannot auto-attach\n");
> > return 0;
> > + }
> >
> > ...as it's a hard issue to spot?
>
> +1 for debug message, but this is not an error condition,
> so I'd say something like "..., skipping auto-attach for struct_ops".
agreed, thinking to make it info-level and only output if we actually
have struct_ops, so not to spam people unnecessarily
