On Mon, Jul 8, 2024 at 5:29 PM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote: > > On 7/8/24 5:26 PM, KP Singh wrote: > > On Mon, Jul 8, 2024 at 5:00 PM Puranjay Mohan <puranjay@xxxxxxxxxx> wrote: > >> > >> Daniel Borkmann <daniel@xxxxxxxxxxxxx> writes: > >> > >>> On 7/5/24 4:50 PM, Puranjay Mohan wrote: > >>>> fexit_sleep test runs successfully now on the CI so remove it from the > >>>> deny list. > >>> > >>> Do you happen to know which commit fixed it? If yes, might be nice to have it > >>> documented in the commit message. > >> > >> Actually, I never saw this test failing on my local setup and yesterday > >> I tried running it on the CI where it passed as well. So, I assumed that > >> this would be fixed by some commit. I am not sure which exact commit > >> might have fixed this. > >> > >> Manu, Martin > >> > >> When this was added to the deny list was this failing every time and did > >> you have some reproducer for this. If there is a reproducer, I can try > >> fixing it but when ran normally this test never fails for me. > > > > I think this never worked until > > https://lore.kernel.org/lkml/20230405180250.2046566-1-revest@xxxxxxxxxxxx/ > > was merged, FTrace direct calls was blocking tracing programs on ARM, > > since then it has always worked. > > Awesome, thanks! I'll add this to the commit desc then when applying. I originally removed that test from the denylist: https://lore.kernel.org/lkml/20230405180250.2046566-6-revest@xxxxxxxxxxxx/ But then it was re-introduced by Martin here: https://lore.kernel.org/bpf/CABRcYmJZ2uUQ4S9rqm+H0N9otjDBv5v45tGjRGKfX2+GZ9gxbw@xxxxxxxxxxxxxx/T/#mc65a794a852bb8b6850cc98be09a90cdc8c76c06 I moved on to work on different things and never investigated it. I don't know what would have broken it and what would have fixed it. I don't remember having observed this "test never returns" problem myself.
