Hi Jakub, Daniel, On Wed, May 22, 2024 at 10:09:36AM +0200, Jakub Sitnicki wrote: > libbpf can deduce program type and attach type from the ELF section name. > We don't need to pass it out-of-band if we switch to libbpf convention [1]. > > [1] https://docs.kernel.org/bpf/libbpf/program_types.html > > Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> > --- > .../selftests/bpf/progs/test_sockmap_kern.h | 17 +++++----- > tools/testing/selftests/bpf/test_sockmap.c | 31 ------------------- > 2 files changed, 9 insertions(+), 39 deletions(-) > [ snip ] I recently hit some CI errors on kernel-patches/bpf related to veristat and the test_sockmap BPF object files: https://github.com/kernel-patches/bpf/actions/runs/9775040227/job/26985293772?pr=7279 I hadn't seen your submission, and after some investigation my own fix ended up reproducing your patch: <sigh...> https://github.com/kernel-patches/bpf/pull/7279/commits/9e5bc23d4a3643e6a4733aac431ee425310e03d6 Given it fixes a CI issue for bpf/master, could we backport/apply your patch there? Thanks, Tony
