Re: [PATCH bpf-next v6 2/9] selftests/bpf: Use start_server_str in sockmap_ktls

[Martin KaFai Lau <martin.lau@xxxxxxxxx>]

On 6/28/24 6:20 PM, Geliang Tang wrote:
>   static void test_sockmap_ktls_disconnect_after_delete(int family, int map)
>   {
> +	struct network_helper_opts opts = {
> +		.backlog = SOMAXCONN,
> +	};
>   	struct sockaddr_storage addr = {0};
>   	socklen_t len = sizeof(addr);
>   	int err, cli, srv, zero = 0;
>   
> -	srv = tcp_server(family);
> +	srv = start_server_str(family, SOCK_STREAM, NULL, 0, &opts);
>   	if (srv == -1)

It should be "if (!ASSERT_GE(srv, 0, ...))" to ensure that the failure is caught 
by the test_progs.