On 12/13/19 3:51 PM, Andrii Nakryiko wrote: > static int > bpf_object__init_internal_map(struct bpf_object *obj, enum libbpf_map_type type, > - int sec_idx, Elf_Data *data) > + int sec_idx, void *data, size_t data_sz) the previous patch set did: bpf_object__init_internal_map(struct bpf_object *obj, enum libbpf_map_type type, - int sec_idx, Elf_Data *data, void **data_buff) + int sec_idx, Elf_Data *data) and now this patch set refactors it again from Elf_Data into two individual arguments. Could you do this right away in the previous set and avoid this churn? Not a strong opinion though. Just odd to see the function being changed back to back. Thankfully that's internal in .c file.