On Thu, 27 Jun 2024 19:38:06 +0200 Oleg Nesterov <oleg@xxxxxxxxxx> wrote: ... > > > +arch_initcall(check_emit_break); > > > + > > > > I wouldn't even bother with this, but whatever. > > Agreed, this looks a bit ugly. I did this only because I can not test > this (hopefully trivial) patch and the maintainers didn't reply. The LoongArch maintainer Huacai told me offline to reply this thread today. > If LoongArch boots at least once with this change, this run-time check > can be removed. I will test it next Monday. > And just in case... I didn't dare to make a more "generic" change, but > perhaps KPROBE_BP_INSN and KPROBE_SSTEPBP_INSN should be redefined the > same way for micro-optimization. In this case __emit_break() should be > probably moved into arch/loongarch/include/asm/inst.h. Yeah. I think so too. Thanks, Tiezhu
