Re: [PATCH 04/39] sched: Add sched_class->reweight_task()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 04/39] sched: Add sched_class->reweight_task()
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Tue, 25 Jun 2024 13:57:37 -1000
Cc: torvalds@xxxxxxxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, juri.lelli@xxxxxxxxxx, vincent.guittot@xxxxxxxxxx, dietmar.eggemann@xxxxxxx, rostedt@xxxxxxxxxxx, bsegall@xxxxxxxxxx, mgorman@xxxxxxx, bristot@xxxxxxxxxx, vschneid@xxxxxxxxxx, ast@xxxxxxxxxx, daniel@xxxxxxxxxxxxx, andrii@xxxxxxxxxx, martin.lau@xxxxxxxxxx, joshdon@xxxxxxxxxx, brho@xxxxxxxxxx, pjt@xxxxxxxxxx, derkling@xxxxxxxxxx, haoluo@xxxxxxxxxx, dvernet@xxxxxxxx, dschatzberg@xxxxxxxx, dskarlat@xxxxxxxxxx, riel@xxxxxxxxxxx, changwoo@xxxxxxxxxx, himadrics@xxxxxxxx, memxor@xxxxxxxxx, andrea.righi@xxxxxxxxxxxxx, joel@xxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, kernel-team@xxxxxxxx
In-reply-to: <20240625072954.GQ31592@noisy.programming.kicks-ass.net>

On Tue, Jun 25, 2024 at 09:29:54AM +0200, Peter Zijlstra wrote:
> On Mon, Jun 24, 2024 at 01:59:02PM -1000, Tejun Heo wrote:
> 
> > Were you trying to say that if the idle policy were to implement
> > ->reweight_task(), it wouldn't be called?
> 
> This. IDLE really is FAIR but with a really small weight.

Oh, right, I got confused (again) by the idle class and SCHED_IDLE. Will
fix.

Thanks.

-- 
tejun

Follow-Ups:
- [PATCH sched_ext/for-6.11] sched_ext: Account for idle policy when setting p->scx.weight in scx_ops_enable_task()
  - From: Tejun Heo
- [PATCH sched/urgent] sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks
  - From: Tejun Heo

References:
- [PATCHSET v6] sched: Implement BPF extensible scheduler class
  - From: Tejun Heo
- [PATCH 04/39] sched: Add sched_class->reweight_task()
  - From: Tejun Heo
- Re: [PATCH 04/39] sched: Add sched_class->reweight_task()
  - From: Peter Zijlstra
- Re: [PATCH 04/39] sched: Add sched_class->reweight_task()
  - From: Tejun Heo
- Re: [PATCH 04/39] sched: Add sched_class->reweight_task()
  - From: Peter Zijlstra

Prev by Date: Re: [PATCH] bpf: defer printk() inside __bpf_prog_run()
Next by Date: Re: [PATCH] bpf: defer printk() inside __bpf_prog_run()
Previous by thread: Re: [PATCH 04/39] sched: Add sched_class->reweight_task()
Next by thread: [PATCH sched/urgent] sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]