Add an option to always return SK_PASS in the verdict callback instead of redirecting the skb. This allows testing cases which are not covered by the test program as of now. Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxxxxxxx> Signed-off-by: John Fastabend <john.fastabend@xxxxxxxxx> --- tools/testing/selftests/bpf/test_sockmap.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 9cba4ec844a5..cc3e4d96c8ac 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -78,6 +78,7 @@ int txmsg_end_push; int txmsg_start_pop; int txmsg_pop; int txmsg_ingress; +int txmsg_pass_skb; int txmsg_redir_skb; int txmsg_ktls_skb; int txmsg_ktls_skb_drop; @@ -108,6 +109,7 @@ static const struct option long_options[] = { {"txmsg_start_pop", required_argument, NULL, 'w'}, {"txmsg_pop", required_argument, NULL, 'x'}, {"txmsg_ingress", no_argument, &txmsg_ingress, 1 }, + {"txmsg_pass_skb", no_argument, &txmsg_pass_skb, 1 }, {"txmsg_redir_skb", no_argument, &txmsg_redir_skb, 1 }, {"ktls", no_argument, &ktls, 1 }, {"peek", no_argument, &peek_flag, 1 }, @@ -177,6 +179,7 @@ static void test_reset(void) txmsg_pass = txmsg_drop = txmsg_redir = 0; txmsg_apply = txmsg_cork = 0; txmsg_ingress = txmsg_redir_skb = 0; + txmsg_pass_skb = 0; txmsg_ktls_skb = txmsg_ktls_skb_drop = txmsg_ktls_skb_redir = 0; txmsg_omit_skb_parser = 0; skb_use_parser = 0; @@ -956,6 +959,7 @@ static int run_options(struct sockmap_options *options, int cg_fd, int test) { int i, key, next_key, err, zero = 0; struct bpf_program *tx_prog; + struct bpf_program *skb_verdict_prog; /* If base test skip BPF setup */ if (test == BASE || test == BASE_SENDPAGE) @@ -972,7 +976,12 @@ static int run_options(struct sockmap_options *options, int cg_fd, int test) } } - links[1] = bpf_program__attach_sockmap(progs[1], map_fd[0]); + if (txmsg_pass_skb) + skb_verdict_prog = progs[2]; + else + skb_verdict_prog = progs[1]; + + links[1] = bpf_program__attach_sockmap(skb_verdict_prog, map_fd[0]); if (!links[1]) { fprintf(stderr, "ERROR: bpf_program__attach_sockmap (sockmap): (%s)\n", strerror(errno)); @@ -1361,6 +1370,8 @@ static void test_options(char *options) } if (txmsg_ingress) append_str(options, "ingress,", OPTSTRING); + if (txmsg_pass_skb) + append_str(options, "pass_skb,", OPTSTRING); if (txmsg_redir_skb) append_str(options, "redir_skb,", OPTSTRING); if (txmsg_ktls_skb) -- 2.33.0