On Fri, 13 Dec 2019 at 16:04, Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Fri, Dec 13, 2019 at 08:51:47AM +0100, Björn Töpel wrote: > > > > > I hope my guess that compiler didn't inline it is correct. Then extra noinline > > > will not hurt and that's the only thing needed to avoid the issue. > > > > > > > I'd say it's broken not marking it as noinline, and I was lucky. It > > would break if other BPF entrypoints that are being called from > > filter.o would appear. I'll wait for more comments, and respin a v5 > > after the weekend. > > Also noticed that EXPORT_SYMBOL for dispatch function is not necessary atm. > Please drop it. It can be added later when need arises. > It's needed for module builds, so I cannot drop it! > With that please respin right away. No need to wait till Monday. > My general approach on accepting patches is "perfect is the enemy of the good". > It's better to land patches sooner if architecture and api looks good. > Details and minor bugs can be worked out step by step. > Ok! Will respin right away!
