Re: [PATCH bpf-next v5 4/6] selftests/bpf: Drop noconnect from network_helper_opts

[Eduard Zingerman <eddyz87@xxxxxxxxx>]

On Wed, 2024-06-19 at 10:51 +0800, Geliang Tang wrote:

Oops, sorry, missed two places that should be changed.
Please keep my ack if you respin.

[...]

> diff --git a/tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c b/tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c
> index 1607a05bf2c2..e73da3de5bf6 100644
> --- a/tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c
> +++ b/tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c

[...]

> @@ -200,7 +199,7 @@ void test_bpf_ip_check_defrag_ok(bool ipv6)
>  	nstoken = open_netns(NS0);
>  	if (!ASSERT_OK_PTR(nstoken, "setns ns0"))
>  		goto out;
> -	client_tx_fd = connect_to_fd_opts(srv_fd, SOCK_RAW, &tx_ops);
> +	client_tx_fd = client_socket(family, SOCK_RAW, &tx_ops);
>  	close_netns(nstoken);
>  	if (!ASSERT_GE(client_tx_fd, 0, "connect_to_fd_opts"))

The ASSERT string should be changed.

>  		goto out;
> @@ -209,7 +208,7 @@ void test_bpf_ip_check_defrag_ok(bool ipv6)
>  	nstoken = open_netns(NS0);
>  	if (!ASSERT_OK_PTR(nstoken, "setns ns0"))
>  		goto out;
> -	client_rx_fd = connect_to_fd_opts(srv_fd, SOCK_DGRAM, &rx_opts);
> +	client_rx_fd = client_socket(family, SOCK_DGRAM, &rx_opts);
>  	close_netns(nstoken);
>  	if (!ASSERT_GE(client_rx_fd, 0, "connect_to_fd_opts"))

The ASSERT string should be changed.

>  		goto out;