Re: [PATCH bpf-next V2 0/3] Fix compiler warnings, looking for suggestions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/06/2024 05:45, Jiri Olsa wrote:
On Fri, Jun 14, 2024 at 11:24:07PM -0300, Rafael Passos wrote:
Hi,
This patchset has a few fixes to compiler warnings.
curious, which compiler/setup displayed the warnings?

It took me a few tries with different configs.
My most successful one was using gcc (14.1.1)
 make -j24 ARCH=x86_64 W=12 2>&1 | tee warnings.log
I dug through the Logs (with grep)looking for BPF and
 non macro expansion warnings.
Thanks!

I am studying the BPF subsystem and wish to bring more tangible contributions.
I would appreciate receiving suggestions on things to investigate.
I also documented a bit in my blog. I could help with docs here, too.
https://rcpassos.me/post/linux-ebpf-understanding-kernel-level-mechanics
Thanks!

Changelog V1 -> V2:
- rebased all commits to updated for-next base
- removes new cases of the extra parameter for bpf_jit_binary_pack_finalize
- built and tested for ARM64
- sent the series for the test workflow:
   https://github.com/kernel-patches/bpf/pull/7198


Rafael Passos (3):
   bpf: remove unused parameter in bpf_jit_binary_pack_finalize
   bpf: remove unused parameter in __bpf_free_used_btfs
   bpf: remove redeclaration of new_n in bpf_verifier_vlog
lgtm, nice cleanup

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

jirka


  arch/arm64/net/bpf_jit_comp.c   | 3 +--
  arch/powerpc/net/bpf_jit_comp.c | 4 ++--
  arch/riscv/net/bpf_jit_core.c   | 5 ++---
  arch/x86/net/bpf_jit_comp.c     | 4 ++--
  include/linux/bpf.h             | 3 +--
  include/linux/filter.h          | 3 +--
  kernel/bpf/core.c               | 8 +++-----
  kernel/bpf/log.c                | 2 +-
  kernel/bpf/verifier.c           | 3 +--
  9 files changed, 14 insertions(+), 21 deletions(-)

--
2.45.2






[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux