On Mon, Jun 10, 2024 at 11:56 AM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote: > > Also note that mark_precise_scalar_ids() needs to be updated > to use mask for ->id extraction. > (Although, that function is broken and I should spill out > v2 of the patch-set that removes it asap). Ahh. Right. I've used #define BPF_ADD_CONST (1U << 31) instead of u32 id:31; u32 add_const:1; to make sure that all ID comparisons in the rest of the verifier are using both id and flag together and idmap stays as-is. I missed mark_precise_scalar_ids() that needs to match what find_equal_scalars() is doing. What's broken in there?
