On Wed, 11 Dec 2019 13:56:09 +0100 Arnd Bergmann <arnd@xxxxxxxx> wrote: > The new driver misses a dependency: > > drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler': > cpsw_new.c:(.text+0x259c): undefined reference to `__page_pool_put_page' > cpsw_new.c:(.text+0x25d0): undefined reference to `page_pool_alloc_pages' > drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels': > cpsw_priv.c:(.text+0x22d8): undefined reference to `page_pool_alloc_pages' > cpsw_priv.c:(.text+0x2420): undefined reference to `__page_pool_put_page' > drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs': > cpsw_priv.c:(.text+0x2624): undefined reference to `page_pool_create' > drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_run_xdp': > cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page' > > Other drivers use 'select' for PAGE_POOL, so do the same here. > > Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx> Thanks for fixing this. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer