Re: [PATCH bpf-next v6 6/8] selftests/bpf: detach a struct_ops link from the subsystem managing it.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ The mailing list got dropped in your reply, so CC back the list ]

On 5/29/24 11:05 PM, Kuifeng Lee wrote:
On Wed, May 29, 2024 at 2:51 PM Martin KaFai Lau <martin.lau@xxxxxxxxx> wrote:

On 5/24/24 3:30 PM, Kui-Feng Lee wrote:
@@ -832,11 +865,20 @@ static int bpf_dummy_reg(void *kdata, struct bpf_link *link)
       if (ops->test_2)
               ops->test_2(4, ops->data);

+     spin_lock(&detach_lock);
+     if (!link_to_detach)
+             link_to_detach = link;

bpf_testmod_ops is used in a few different tests now. Can you check if
"./test_progs -j <num_of_parallel_workers>" will work considering link_to_detach
here is the very first registered link.

Yes, it works.  Since the test in test_struct_ops_modules.c is serial,
no other test will
be run simultaneously. And its subtests are run one after another.

just did a quick search on "bpf_map__attach_struct_ops", how about the other tests like struct_ops_autocreate.c and test_struct_ops_multi_pages.c ?




+     spin_unlock(&detach_lock);
+
       return 0;
   }






[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux