On Fri, May 24, 2024 at 1:52 PM Ian Rogers <irogers@xxxxxxxxxx> wrote: > > Allow uid and gid to be terms in BPF filters by first breaking the > connection between filter terms and PERF_SAMPLE_xx values. Calculate > the uid and gid using the bpf_get_current_uid_gid helper, rather than > from a value in the sample. Allow filters to be passed to perf top, this allows: > > $ perf top -e cycles:P --filter "uid == $(id -u)" > > to work as a "perf top -u" workaround, as "perf top -u" usually fails > due to processes/threads terminating between the /proc scan and the > perf_event_open. > > v3. Move PERF_SAMPLE_xx asserts to sample_filter.bpf.c to avoid > conflicting definitions between vmlinux.h and perf_event.h as > reported by Namhyung. > v2. Allow PERF_SAMPLE_xx to be computed from the PBF_TERM_xx value > using a shift as requested by Namhyung. > > Ian Rogers (3): > perf bpf filter: Give terms their own enum > perf bpf filter: Add uid and gid terms > perf top: Allow filters on events Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx> Thanks, Namhyung > > tools/perf/Documentation/perf-record.txt | 2 +- > tools/perf/Documentation/perf-top.txt | 4 ++ > tools/perf/builtin-top.c | 9 +++ > tools/perf/util/bpf-filter.c | 33 +++++---- > tools/perf/util/bpf-filter.h | 5 +- > tools/perf/util/bpf-filter.l | 66 +++++++++--------- > tools/perf/util/bpf-filter.y | 7 +- > tools/perf/util/bpf_skel/sample-filter.h | 40 ++++++++++- > tools/perf/util/bpf_skel/sample_filter.bpf.c | 73 +++++++++++++++----- > 9 files changed, 169 insertions(+), 70 deletions(-) > > -- > 2.45.1.288.g0e0cd299f1-goog >
