>-----Original Message----- >From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of >Zaremba, Larysa >Sent: Wednesday, May 15, 2024 9:32 PM >To: intel-wired-lan@xxxxxxxxxxxxxxxx; Keller, Jacob E <jacob.e.keller@xxxxxxxxx> >Cc: Fijalkowski, Maciej <maciej.fijalkowski@xxxxxxxxx>; Jesper Dangaard Brouer ><hawk@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; Zaremba, >Larysa <larysa.zaremba@xxxxxxxxx>; Kitszel, Przemyslaw ><przemyslaw.kitszel@xxxxxxxxx>; John Fastabend ><john.fastabend@xxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; David S. >Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; >netdev@xxxxxxxxxxxxxxx; Jakub Kicinski <kuba@xxxxxxxxxx>; >bpf@xxxxxxxxxxxxxxx; Paolo Abeni <pabeni@xxxxxxxxxx>; Magnus Karlsson ><magnus.karlsson@xxxxxxxxx>; Bagnucki, Igor <igor.bagnucki@xxxxxxxxx>; >linux-kernel@xxxxxxxxxxxxxxx >Subject: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps >bitmap > >Referenced commit has introduced a bitmap to distinguish between ZC and >copy-mode AF_XDP queues, because xsk_get_pool_from_qid() does not do >this for us. > >The bitmap would be especially useful when restoring previous state after >rebuild, if only it was not reallocated in the process. This leads to e.g. >xdpsock dying after changing number of queues. > >Instead of preserving the bitmap during the rebuild, remove it completely and >distinguish between ZC and copy-mode queues based on the presence of a >device associated with the pool. > >Fixes: e102db780e1c ("ice: track AF_XDP ZC enabled queues in bitmap") >Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx> >Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx> >--- > drivers/net/ethernet/intel/ice/ice.h | 32 ++++++++++++++++-------- > drivers/net/ethernet/intel/ice/ice_lib.c | 8 ------ >drivers/net/ethernet/intel/ice/ice_xsk.c | 13 +++++----- > 3 files changed, 27 insertions(+), 26 deletions(-) > Tested-by: Chandan Kumar Rout <chandanx.rout@xxxxxxxxx> (A Contingent Worker at Intel)