On Tue, May 28, 2024 at 11:23:05AM +0100, Russell King (Oracle) wrote: > On Sat, May 25, 2024 at 12:02:59AM +0300, Serge Semin wrote: > > First of all the flags are never set by any of the driver parts. If nobody > > have them set then the respective statements will always have the same > > result. Thus the statements can be simplified or even dropped with no risk > > to break things. > > > > Secondly shall any of the TBI or RTBI flag is set the MDIO-bus > > registration will be bypassed. Why? It really seems weird. It's perfectly > > fine to have a TBI/RTBI-capable PHY configured over the MDIO bus > > interface. > > > > Based on the notes above the TBI/RTBI PCS flags can be freely dropped thus > > simplifying the driver code. > > > > Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx> > > I think this patch can come first in the series, along with another > few patches that remove stuff. Any objection? No objection. -Serge(y) > > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
