Hi Jakub, On Wed, 2024-05-22 at 12:26 +0200, Jakub Sitnicki wrote: > On Wed, May 22, 2024 at 06:12 PM +08, Geliang Tang wrote: > > On Wed, 2024-05-22 at 10:09 +0200, Jakub Sitnicki wrote: > > [...] > > > prog_attach_type is still used by my commit: > > > > https://lore.kernel.org/bpf/e27d7d0c1e0e79b0acd22ac6ad5d8f9f00225303.1716372485.git.tanggeliang@xxxxxxxxxx/T/#u I changes my commit above as "Rejected". So this patch is ready to apply now. > > Please review it for me. > > > > If my commit is acceptable, this patch will conflict with it. It's > > a > > bit strange to delete this prog_attach_type in your patch and then > > add > > it back in my commit. So could you please rebase this patch on my > > commit in that case. Sorry for the trouble. > > If you want to help improve and modernize this test code, I suggest > switching attachments to bpf_link instead, they are now available for > sockmap: Here's the patches for switching attachments to bpf_link, together with some small fixes and cleanups: https://patchwork.kernel.org/project/netdevbpf/cover/cover.1716446893.git.tanggeliang@xxxxxxxxxx/ Please review them for me. Thanks, -Geliang > > https://lore.kernel.org/bpf/20240408152451.4162024-1-yonghong.song@xxxxxxxxx/ >