On Mon, 9 Dec 2019 at 14:55, Björn Töpel <bjorn.topel@xxxxxxxxx> wrote: > [...] > > Discussion/feedback > =================== > > My measurements did not show any improvements for the jump target 16 B > alignments. Maybe it would make sense to leave alignment out? > I did a micro benchmark with "test_progs -t xdp_prog" for all sizes (max 48 aligned, max 64 non-aligned) of the dispatcher. I couldn't measure any difference at all, so I will leave the last patch out (aligning jump targets). If a workload appears where this is measurable, it can be added at that point. The micro benchmark also show that it makes little sense disabling the dispatcher when "mitigations=off". The diff is within 1ns(!), when mitigations are off. I'll post the data as a reply to the v4 cover letter, so that the cover isn't clobbered with data. :-P Björn
