On Mon, Dec 9, 2019 at 5:33 PM Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote: > > On Mon, 9 Dec 2019 17:14:26 -0800, Andrii Nakryiko wrote: > > Few libbpf APIs are not public but currently exposed through libbpf.h to be > > used by bpftool. Move them to libbpf_internal.h, where intent of being > > non-stable and non-public is much more obvious. > > > > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> > > --- > > tools/bpf/bpftool/net.c | 1 + > > tools/lib/bpf/libbpf.h | 17 ----------------- > > tools/lib/bpf/libbpf_internal.h | 17 +++++++++++++++++ > > 3 files changed, 18 insertions(+), 17 deletions(-) > > > > diff --git a/tools/bpf/bpftool/net.c b/tools/bpf/bpftool/net.c > > index 4f52d3151616..d93bee298e54 100644 > > --- a/tools/bpf/bpftool/net.c > > +++ b/tools/bpf/bpftool/net.c > > @@ -18,6 +18,7 @@ > > > > #include <bpf.h> > > #include <nlattr.h> > > +#include "libbpf_internal.h" > > #include "main.h" > > #include "netlink_dumper.h" > > I thought this idea was unpopular when proposed? There was a recent discussion about the need for unstable APIs to be exposed to bpftool and we concluded that libbpf_internal.h is the most appropriate place to do this.
