On 5/16/24 5:54 PM, Amery Hung wrote:
The part that no skb acquire kfunc should be available to the qdisc struct_ops
prog is understood. I think it just needs to clarify the commit message and
remove the "It must be released and cannot be acquired more than once" part.
Got it. I will improve the clarity of the commit message.
In addition, I will also remove "struct_ops_ref_acquire_dup_ref.c" as
whether duplicate references can be acquired through kfunc is out of
scope (should be taken care of by struct_ops implementer). Actually,
this testcase should load the and it does load...
As for the name, do you have any thoughts?
Naming is hard... :(
May be just keep it short, just "__ref"?