On Wed, May 15, 2024 at 06:02:16PM +0200, Larysa Zaremba wrote: > ice_pf_dcb_recfg() re-maps queues to vectors with > ice_vsi_map_rings_to_vectors(), which does not restore the previous > state for XDP queues. This leads to no AF_XDP traffic after rebuild. > > Map XDP queues to vectors in ice_vsi_map_rings_to_vectors(). > Also, move the code around, so XDP queues are mapped independently only > through .ndo_bpf(). Hi Larysa, I take it the last sentence refers to the placement of ice_map_xdp_rings() in ice_prepare_xdp_rings() after rather than before the (cfg_type == ICE_XDP_CFG_PART) condition. If so, I see that it is a small change. But I do wonder if it is separate from fixing the issue described in the first paragraph. And thus would be better as a separate patch. Also, (I'm raising a separate issue :) breaking out logic into ice_xdp_ring_from_qid() seems very nice. But I wonder if this ought to be part of a cleanup-patch for 'iwl' rather than a fixes patch for 'iwl-next'. OTOH, I do see that breaking out ice_map_xdp_rings() makes sense in the context of this fix as the same logic is to be called in two places. Splitting patches aside, the resulting code looks good to me. ...
