err is a 32-bit integer, but elf_update returns an off_t, which is
64-bit at least on 64-bit platforms. If symbols_patch is called on a
binary between 2-4GB in size, the result will be negative when cast to
a 32-bit integer, which the code assumes means an error occurred. This
can wrongly trigger build failures when building very large kernel
images.
Signed-off-by: Friedrich Vock <friedrich.vock@xxxxxx>
Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
---
tools/bpf/resolve_btfids/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index d9520cb826b31..af393c7dee1f1 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -728,7 +728,7 @@ static int sets_patch(struct object *obj)
static int symbols_patch(struct object *obj)
{
- int err;
+ off_t err;
if (__symbols_patch(obj, &obj->structs) ||
__symbols_patch(obj, &obj->unions) ||
--
2.45.0
