On Thu, May 9, 2024 at 11:31 AM Matthieu Baerts <matttbe@xxxxxxxxxx> wrote: > > Hello, > > On 09/05/2024 17:49, Matthieu Baerts (NGI0) wrote: > > From: Geliang Tang <tanggeliang@xxxxxxxxxx> > > > > This patch adds a subtest named test_subflow to load and verify the newly > > added mptcp subflow example in test_mptcp. Add a helper endpoint_init() > > to add a new subflow endpoint. Add another helper ss_search() to verify the > > fwmark and congestion values set by mptcp_subflow prog using setsockopts. > > > > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/76 > > Signed-off-by: Geliang Tang <tanggeliang@xxxxxxxxxx> > > Reviewed-by: Mat Martineau <martineau@xxxxxxxxxx> > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx> > > --- > > tools/testing/selftests/bpf/prog_tests/mptcp.c | 109 +++++++++++++++++++++++++ > > 1 file changed, 109 insertions(+) > > > > diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c > > index 274d2e033e39..6039b0ff3801 100644 > > --- a/tools/testing/selftests/bpf/prog_tests/mptcp.c > > +++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c > > (...) > > > @@ -340,10 +344,115 @@ static void test_mptcpify(void) > > close(cgroup_fd); > > } > > > > +static int endpoint_init(char *flags) > > +{ > > + SYS(fail, "ip -net %s link add veth1 type veth peer name veth2", NS_TEST); > > + SYS(fail, "ip -net %s addr add %s/24 dev veth1", NS_TEST, ADDR_1); > > + SYS(fail, "ip -net %s link set dev veth1 up", NS_TEST); > > + SYS(fail, "ip -net %s addr add %s/24 dev veth2", NS_TEST, ADDR_2); > > + SYS(fail, "ip -net %s link set dev veth2 up", NS_TEST); > > + SYS(fail, "ip -net %s mptcp endpoint add %s %s", NS_TEST, ADDR_2, flags); > > I just noticed that this command is failing on the BPF CI: > > https://github.com/kernel-patches/bpf/actions/runs/9020020315?pr=7009 > > Is it possible that an old version of IPRoute2 is installed? > 'ip mptcp' is supported since v5.8.0 (from 2020). > > It looks like Ubuntu Focal 20.04 is being used, which has the v5.5.0. Do > we then need to find another way to set the MPTCP endpoints? Manu, any idea?
