Hi Yabin, kernel test robot noticed the following build errors: [auto build test ERROR on perf-tools-next/perf-tools-next] [also build test ERROR on tip/perf/core linus/master v6.9-rc7 next-20240510] [cannot apply to acme/perf/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yabin-Cui/perf-core-Save-raw-sample-data-conditionally-based-on-sample-type/20240510-083817 base: https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git perf-tools-next patch link: https://lore.kernel.org/r/20240510002424.1277314-4-yabinc%40google.com patch subject: [PATCH v3 3/3] perf: core: Check sample_type in perf_sample_save_brstack config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20240510/202405101855.doEob5FK-lkp@xxxxxxxxx/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405101855.doEob5FK-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202405101855.doEob5FK-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from include/linux/trace_events.h:10, from include/trace/syscall.h:7, from include/linux/syscalls.h:93, from kernel/time/time.c:33: include/linux/perf_event.h: In function 'perf_sample_save_brstack': >> include/linux/perf_event.h:1279:14: error: implicit declaration of function 'has_branch_stack' [-Werror=implicit-function-declaration] 1279 | if (!has_branch_stack(event)) | ^~~~~~~~~~~~~~~~ include/linux/perf_event.h: At top level: >> include/linux/perf_event.h:1671:20: error: conflicting types for 'has_branch_stack'; have 'bool(struct perf_event *)' {aka '_Bool(struct perf_event *)'} 1671 | static inline bool has_branch_stack(struct perf_event *event) | ^~~~~~~~~~~~~~~~ include/linux/perf_event.h:1279:14: note: previous implicit declaration of 'has_branch_stack' with type 'int()' 1279 | if (!has_branch_stack(event)) | ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/trace_events.h:10, from include/trace/syscall.h:7, from include/linux/syscalls.h:93, from kernel/time/hrtimer.c:30: include/linux/perf_event.h: In function 'perf_sample_save_brstack': >> include/linux/perf_event.h:1279:14: error: implicit declaration of function 'has_branch_stack' [-Werror=implicit-function-declaration] 1279 | if (!has_branch_stack(event)) | ^~~~~~~~~~~~~~~~ include/linux/perf_event.h: At top level: >> include/linux/perf_event.h:1671:20: error: conflicting types for 'has_branch_stack'; have 'bool(struct perf_event *)' {aka '_Bool(struct perf_event *)'} 1671 | static inline bool has_branch_stack(struct perf_event *event) | ^~~~~~~~~~~~~~~~ include/linux/perf_event.h:1279:14: note: previous implicit declaration of 'has_branch_stack' with type 'int()' 1279 | if (!has_branch_stack(event)) | ^~~~~~~~~~~~~~~~ kernel/time/hrtimer.c:121:35: warning: initialized field overwritten [-Woverride-init] 121 | [CLOCK_REALTIME] = HRTIMER_BASE_REALTIME, | ^~~~~~~~~~~~~~~~~~~~~ kernel/time/hrtimer.c:121:35: note: (near initialization for 'hrtimer_clock_to_base_table[0]') kernel/time/hrtimer.c:122:35: warning: initialized field overwritten [-Woverride-init] 122 | [CLOCK_MONOTONIC] = HRTIMER_BASE_MONOTONIC, | ^~~~~~~~~~~~~~~~~~~~~~ kernel/time/hrtimer.c:122:35: note: (near initialization for 'hrtimer_clock_to_base_table[1]') kernel/time/hrtimer.c:123:35: warning: initialized field overwritten [-Woverride-init] 123 | [CLOCK_BOOTTIME] = HRTIMER_BASE_BOOTTIME, | ^~~~~~~~~~~~~~~~~~~~~ kernel/time/hrtimer.c:123:35: note: (near initialization for 'hrtimer_clock_to_base_table[7]') kernel/time/hrtimer.c:124:35: warning: initialized field overwritten [-Woverride-init] 124 | [CLOCK_TAI] = HRTIMER_BASE_TAI, | ^~~~~~~~~~~~~~~~ kernel/time/hrtimer.c:124:35: note: (near initialization for 'hrtimer_clock_to_base_table[11]') cc1: some warnings being treated as errors vim +/has_branch_stack +1279 include/linux/perf_event.h 1271 1272 static inline void perf_sample_save_brstack(struct perf_sample_data *data, 1273 struct perf_event *event, 1274 struct perf_branch_stack *brs, 1275 u64 *brs_cntr) 1276 { 1277 int size = sizeof(u64); /* nr */ 1278 > 1279 if (!has_branch_stack(event)) 1280 return; 1281 1282 if (branch_sample_hw_index(event)) 1283 size += sizeof(u64); 1284 size += brs->nr * sizeof(struct perf_branch_entry); 1285 1286 /* 1287 * The extension space for counters is appended after the 1288 * struct perf_branch_stack. It is used to store the occurrences 1289 * of events of each branch. 1290 */ 1291 if (brs_cntr) 1292 size += brs->nr * sizeof(u64); 1293 1294 data->br_stack = brs; 1295 data->br_stack_cntr = brs_cntr; 1296 data->dyn_size += size; 1297 data->sample_flags |= PERF_SAMPLE_BRANCH_STACK; 1298 } 1299 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
