On 10/05/2024 00:24, Alexei Starovoitov wrote: > On Thu, May 9, 2024 at 4:09 PM Quentin Monnet <qmo@xxxxxxxxxx> wrote: >> >> Nit: Most variables in the file are declared in "reverse-Christmas-tree" >> order (longest lines first, unless there's a reason not to). Could you >> please try to preserve this order, here and elsewhere, for consistency? > > I so hate this nitpick. Yes, I've seen you push back before; I was wondering if you'd react on this one. I don't mind too much about the ordering, to be honest. To me, this is mostly a matter of consistency in the file. > I'll start introducing non-rev-xmas tree everywhere just > to stop this madness. That's maybe not necessary :), at least as far as I'm concerned. I'm fine with dropping this for future reviews (starting with the current one). Quentin
