On Thu, May 9, 2024 at 10:50 AM Martin KaFai Lau <martin.lau@xxxxxxxxx> wrote: > > From: Martin KaFai Lau <martin.lau@xxxxxxxxxx> > > The earlier commit 8e6d9ae2e09f ("selftests/bpf: Use bpf_tracing.h instead of bpf_tcp_helpers.h") > removed the bpf_tcp_helpers.h usages from the non networking tests. > > This patch set is a continuation of this effort to retire > the bpf_tcp_helpers.h from the networking tests (mostly tcp-cc related). > > The main usage of the bpf_tcp_helpers.h is the partial kernel > socket definitions (e.g. sock, tcp_sock). New fields are kept adding > back to those partial socket definitions while everything is available > in the vmlinux.h. The recent bpf_cc_cubic.c test tried to extend > bpf_tcp_helpers.c but eventually used the vmlinux.h instead. To avoid > this unnecessary detour for new tests and have one consistent way > of using the kernel sockets, this patch set retires the bpf_tcp_helpers.h > usages and consolidates the tests to use vmlinux.h instead. Nice cleanup! Applied.