> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On > Behalf Of Alexander Lobakin > Sent: Wednesday, May 8, 2024 4:40 PM > To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Alexei Starovoitov <ast@xxxxxxxxxx>; Jesper Dangaard Brouer > <hawk@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; > netdev@xxxxxxxxxxxxxxx; Richard Cochran <richardcochran@xxxxxxxxx>; > John Fastabend <john.fastabend@xxxxxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; Eric Dumazet <edumazet@xxxxxxxxxx>; intel- > wired-lan@xxxxxxxxxxxxxxxx; Jakub Kicinski <kuba@xxxxxxxxxx>; > Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; Nguyen, Anthony L > <anthony.l.nguyen@xxxxxxxxx>; bpf@xxxxxxxxxxxxxxx; Paolo Abeni > <pabeni@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx> > Subject: Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: > Use *-y instead of *-objs in Makefile > > From: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> > Date: Wed, 8 May 2024 16:39:21 +0200 > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Date: Wed, 8 May 2024 17:25:31 +0300 > > > >> On Wed, May 08, 2024 at 03:35:26PM +0200, Alexander Lobakin > wrote: > >>>> *-objs suffix is reserved rather for (user-space) host > programs > >>>> while usually *-y suffix is used for kernel drivers (although > >>>> *-objs works for that purpose for now). > >>>> > >>>> Let's correct the old usages of *-objs in Makefiles. > >>> > >>> Wait, I was sure I've seen somewhere that -objs is more new and > >>> preferred over -y. > >> > >> Then you are mistaken. > >> > >>> See recent dimlib comment where Florian changed -y to -objs for > >>> example. > >> > >> So does he :-) > >> > >>> Any documentation reference that -objs is for userspace and we > >>> should clearly use -y? > >> > >> Sure. Luckily it's documented in > Documentation/kbuild/makefiles.rst > >> "Composite Host Programs" (mind the meaning of the word > "host"!). > > > > Oh okay, I see. `-objs` is indeed only mentioned in the host > chapter. > > Reviewed-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> > > Thanks, > Olek Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
