On Tue, May 7, 2024 at 7:36 AM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Mon, May 6, 2024 at 7:46 PM Haiyue Wang <haiyue.wang@xxxxxxxxx> wrote: > > > > Rename the kfunc set variable to specify the 'arena' function scope, > > although the 'UNSPEC' type BPF program is mapped to 'COMMON' hook. > > > > And there is 'common_kfunc_set' defined for real 'common' function in > > file 'kernel/bpf/helpers.c'. > > I think common_kfunc_set is a better name to describe that these > two kfuncs are in a common category. > BPF_PROG_TYPE_UNSPEC is a lot less obvious. > > There are two static common_kfunc_set in helpers.c and arena.c > and that's fine. it is actually confusing when reading/grepping code, though, so why not have arena_common_kfunc_set and whatever the meaningful "qualifier" name for the other one? > > pw-bot: cr
