On 5/2/24 18:04, Puranjay Mohan wrote: > arch_timer.h includes linux/smp.h to use DEFINE_PER_CPU() and it works > because smp.h includes percpu.h. The next commit will remove percpu.h > from smp.h and it will break this usage. > > Explicitly include percpu.h and remove smp.h But this particular change does not seem to be necessary for changing raw_smp_processor_id() as current_thread_info()->cpu being done in the later patch ? You might still leave header <asm/percpu.h> inclusion in arch/arm64/include/asm/smp.h while dropping the per cpu cpu_number ? > > Signed-off-by: Puranjay Mohan <puranjay@xxxxxxxxxx> > --- > arch/arm64/include/asm/arch_timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h > index 934c658ee947..f5794d50f51d 100644 > --- a/arch/arm64/include/asm/arch_timer.h > +++ b/arch/arm64/include/asm/arch_timer.h > @@ -15,7 +15,7 @@ > #include <linux/bug.h> > #include <linux/init.h> > #include <linux/jump_label.h> > -#include <linux/smp.h> > +#include <linux/percpu.h> > #include <linux/types.h> > > #include <clocksource/arm_arch_timer.h>