On Fri, Apr 26, 2024 at 5:17 AM Viktor Malik <vmalik@xxxxxxxxxx> wrote: > > In some situations, it is useful to explicitly specify a kernel module > to search for a tracing program target (e.g. when a function of the same > name exists in multiple modules or in vmlinux). > > This change enables that by allowing the "module:function" syntax for > the find_kernel_btf_id function. Thanks to this, the syntax can be used > both from a SEC macro (i.e. `SEC(fentry/module:function)`) and via the > bpf_program__set_attach_target API call. > how about function[module] syntax. This follows how modules are reported in kallsyms and a bunch of other kernel-generated files. I've been using this syntax in retsnoop for a while, and it feels very natural. It's also distinctive enough to be recognizable and parseable without any possible confusions. Can you please also check if we can/should support this for kprobes as well? > Viktor Malik (2): > libbpf: support "module:function" syntax for tracing programs > selftests/bpf: add tests for the "module:function" syntax > > tools/lib/bpf/libbpf.c | 33 ++++++++++++++----- > .../selftests/bpf/prog_tests/module_attach.c | 6 ++++ > .../selftests/bpf/progs/test_module_attach.c | 23 +++++++++++++ > 3 files changed, 53 insertions(+), 9 deletions(-) > > -- > 2.44.0 >
