Re: [PATCH v2] tools/build: Add clang cross-compilation flags to feature detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jiri Olsa <olsajiri@xxxxxxxxx> writes:

> On Thu, Nov 02, 2023 at 11:32:52AM +0100, Björn Töpel wrote:
>> From: Björn Töpel <bjorn@xxxxxxxxxxxx>
>> 
>> When a tool cross-build has LLVM=1 set, the clang cross-compilation
>> flags are not passed to the feature detection build system. This
>> results in the host's features are detected instead of the targets.
>> 
>> E.g, triggering a cross-build of bpftool:
>> 
>>   cd tools/bpf/bpftool
>>   make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- LLVM=1
>> 
>> would report the host's, and not the target's features.
>> 
>> Correct the issue by passing the CLANG_CROSS_FLAGS variable to the
>> feature detection makefile.
>> 
>> Fixes: cebdb7374577 ("tools: Help cross-building with clang")
>> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxxxx>
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Waking up the dead!

Arnaldo, Jean-Philippe: I'm still stung by what this patch fixes. LMK
what you need from me/this patch to pick it up.


Cheers,
Björn





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux