Re: [PATCH bpf-next v1 1/2] bpf: Introduce bpf_preempt_[disable,enable] kfuncs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Apr 2024 at 16:59, Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Mon, Apr 22, 2024 at 11:19 PM Kumar Kartikeya Dwivedi
> <memxor@xxxxxxxxx> wrote:
> > @@ -10987,6 +11006,8 @@ enum special_kfunc_type {
> >         KF_bpf_percpu_obj_drop_impl,
> >         KF_bpf_throw,
> >         KF_bpf_iter_css_task_new,
> > +       KF_bpf_preempt_disable,
> > +       KF_bpf_preempt_enable,
> >  };
> >
> >  BTF_SET_START(special_kfunc_set)
> > @@ -11043,6 +11064,8 @@ BTF_ID(func, bpf_iter_css_task_new)
> >  #else
> >  BTF_ID_UNUSED
> >  #endif
> > +BTF_ID(func, bpf_preempt_disable)
> > +BTF_ID(func, bpf_preempt_enable)
>
> I suspect this is broken on !CONFIG_CGROUPS,
> since KF_bpf_preempt_disable number won't match the ID in the list.
> The simplest fix is to move these two up before bpf_iter_css_task_new.

Will fix, thanks for noticing.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux