On Fri, Apr 19, 2024 at 8:14 AM Benjamin Tissoires <bentiss@xxxxxxxxxx> wrote: > > > Honestly I just felt the patch series was big enough for a PoC and > comparison with sleepable bpf_timer. But if we think this needs not to > be added, I guess that works too :) It certainly did its job to compare the two and imo bpf_wq with kfunc approach looks cleaner overall and will be easier to extend in the long term. I mean that we'll be adding 3 kfuncs initially: bpf_wq_init, bpf_wq_start, bpf_wq_set_callback. imo that's good enough to land it and get some exposure. I'll be using it right away to refactor bpf_arena_alloc.h into actual arena allocator for bpf progs that is not just a selftest. I'm currently working on locks for bpf_arena. Kumar has a patch set that adds bpf_preempt_disble kfunc and coupled with bpf_wq we'll have all mechanisms to build arbitrary data structures/algorithms as bpf programs.
