On Wed, Apr 17, 2024 at 09:26:03AM +0300, Dmitrii Bundin wrote:
> On Tue, Apr 16, 2024 at 5:47 PM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
> > Please add the error description as motivation aka "why" into the commit
> > description, otherwise it's not really obvious looking at it at a later
> > point in time why the include was needed.
>
> Doesn't the comment /* for u32 */ following the include explain the
> purpose? I thought the include was actually missing since relying on
> indirect declaration of u32 is relatively fragile.
I think you can add similar descirption as for the already merged tool
change in bpf/master, and also include the Fixes/stable tags
commit 62248b22d01e96a4d669cde0d7005bd51ebf9e76
Author: Natanael Copa <ncopa@xxxxxxxxxxxxxxx>
Date: Thu Mar 28 11:59:13 2024 +0100
tools/resolve_btfids: fix build with musl libc
Include the header that defines u32.
This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.
Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Natanael Copa <ncopa@xxxxxxxxxxxxxxx>
Tested-by: Greg Thelen <gthelen@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20240328110103.28734-1-ncopa@xxxxxxxxxxxxxxx
Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
jirka
