> -----Original Message----- > From: Julien Panis <jpanis@xxxxxxxxxxxx> > Sent: Friday, April 12, 2024 7:02 AM > To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; David S. Miller > <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski > <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Russell King > <linux@xxxxxxxxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann > <daniel@xxxxxxxxxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John > Fastabend <john.fastabend@xxxxxxxxx>; Sumit Semwal > <sumit.semwal@xxxxxxxxxx>; Christian König <christian.koenig@xxxxxxx>; Simon > Horman <horms@xxxxxxxxxx>; Andrew Lunn <andrew@xxxxxxx>; Ratheesh > Kannoth <rkannoth@xxxxxxxxxxx>; Naveen Mamindlapalli > <naveenm@xxxxxxxxxxx> > Cc: danishanwar@xxxxxx; yuehaibing@xxxxxxxxxx; rogerq@xxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; linux- > media@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linaro-mm- > sig@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW > Ethernet driver > > On 4/10/24 01:51, Jacob Keller wrote: > > > > On 4/8/2024 2:38 AM, Julien Panis wrote: > >> This patch adds XDP support to TI AM65 CPSW Ethernet driver. > >> > >> The following features are implemented: NETDEV_XDP_ACT_BASIC, > >> NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT. > >> > >> Zero-copy and non-linear XDP buffer supports are NOT implemented. > >> > >> Besides, the page pool memory model is used to get better performance. > >> > >> Signed-off-by: Julien Panis <jpanis@xxxxxxxxxxxx> > >> --- > > Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx> > > Thank you for your review Jacob. > I'll add your 'Reviewed-by' tag for PATCH 1/3 in next version. Unfortunately, > I will not for PATCH 2/3 and 3/3 because there will be too many changes, > following Jakub's comments. Sounds good. Feel free to CC me on the next version too and I can review the new changes 😊
