On Sat, 6 Apr 2024 at 09:01, Martin KaFai Lau <martin.lau@xxxxxxxxx> wrote: > How about the other fields (flags and dir) in the "struct nf_conntrack_zone" and > would it be useful to have values other than the default? Good question, it would probably be useful to make these configurable as well. My reason for only adding ct zone id was to avoid changing the size of bpf_ct_opts (NF_BPF_CT_OPTS_SZ). I would be interested in some opinions here on if it's acceptable to increase the size of bpf_ct_opts, if so, should I also add back some reserved options to the struct for future use? > Can it actually test an alloc and lookup of a non default zone id? Yes, I have a test written now and will include this in my v2 submission. > Please also separate the selftest into another patch. Will do.