On 4/10/2024 8:30 AM, Willem de Bruijn wrote: > Abhishek Chauhan wrote: >> mono_delivery_time was added to check if skb->tstamp has delivery >> time in mono clock base (i.e. EDT) otherwise skb->tstamp has >> timestamp in ingress and delivery_time at egress. >> >> Renaming the bitfield from mono_delivery_time to tstamp_type is for >> extensibilty for other timestamps such as userspace timestamp >> (i.e. SO_TXTIME) set via sock opts. >> >> Bridge driver today has no support to forward the userspace timestamp >> packets and ends up resetting the timestamp. ETF qdisc checks the >> packet coming from userspace and encounters to be 0 thereby dropping >> time sensitive packets. These changes will allow userspace timestamps >> packets to be forwarded from the bridge to NIC drivers. >> >> In future tstamp_type:1 can be extended to support userspace timestamp >> by increasing the bitfield. >> >> Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@xxxxxxxxx/ >> Signed-off-by: Abhishek Chauhan <quic_abchauha@xxxxxxxxxxx> >> --- >> include/linux/skbuff.h | 18 +++++++++--------- >> include/net/inet_frag.h | 4 ++-- >> net/bridge/netfilter/nf_conntrack_bridge.c | 6 +++--- >> net/core/dev.c | 2 +- >> net/core/filter.c | 8 ++++---- >> net/ipv4/inet_fragment.c | 2 +- >> net/ipv4/ip_fragment.c | 2 +- >> net/ipv4/ip_output.c | 8 ++++---- >> net/ipv6/ip6_output.c | 6 +++--- >> net/ipv6/netfilter.c | 6 +++--- >> net/ipv6/netfilter/nf_conntrack_reasm.c | 2 +- >> net/ipv6/reassembly.c | 2 +- >> net/sched/act_bpf.c | 4 ++-- >> net/sched/cls_bpf.c | 4 ++-- >> 14 files changed, 37 insertions(+), 37 deletions(-) > > Since the next patch against touches many of the same lines, probably > can just squash the two. Sounds good i can do that. Make only 2 patches 1. rename + assign tstamp_type 2. introduce another bit for clock_id base time
