On Wed, Nov 27, 2019 at 5:17 PM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote: > > On November 27, 2019 9:59:15 PM GMT-03:00, Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > >On Wed, Nov 27, 2019 at 4:50 PM Arnaldo Carvalho de Melo > ><arnaldo.melo@xxxxxxxxx> wrote: > >> > >> Take it as one, I think it's what should have been in the cset it is > >fixing, that way no breakage would have happened. > > > >Ok. I trimmed commit log and applied here: > >https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=1fd450f99272791df8ea8e1b0f5657678e118e90 > > > >What about your other fix and my suggestion there? > >(__u64) cast instead of PRI ? > >We do this already in two places: > >libbpf.c: shdr_idx, (__u64)sym->st_value); > >libbpf.c: (__u64)sym.st_value, GELF_ST_TYPE(sym.st_info), > > > I'm using the smartphone now, but I thought you first suggested using a cast to long, if you mean using %llu + cast to __u64, then should be was ugly as using PRI, IOW, should work on both 64 bit and 32 bit. :-) Yes. I suggested (long) first, but then found two cases in libbpf that solve this with (__u64), so better to stick to that for consistency.
