On Wed, Apr 3, 2024, at 23:00, Daniel Borkmann wrote:
> On 4/3/24 10:09 PM, Arnd Bergmann wrote:
>> On Wed, Apr 3, 2024, at 14:33, Anton Protopopov wrote:
>>>
>>> Declare this inner union as __attribute__((packed, aligned(2))) such
>>> that it always is of size 2 and is aligned to 16 bits.
>>
>> I think you probably want 32-bit alignment for the structure,
>> to keep the ABI unchanged on all other architectures.
>
> Fwiw, on x86 nothing should change on this regard, see below pahole dump
> before/after. I think similar might be true for other archs as otherwise
> we should have seen a kbuild bot complaint on hitting the size assert.
It's not the structure layout that changes, just its alignment.
Of course this is unlikely to cause actual bugs, but if there there
is no real need to change it, I would leave the alignment the same
as before.
Arnd
