Em Wed, Nov 27, 2019 at 03:52:06PM +0000, Quentin Monnet escreveu: > 2019-11-27 12:48 UTC-0300 ~ Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> > > Em Wed, Nov 27, 2019 at 02:31:31PM +0000, Quentin Monnet escreveu: > >> 2019-11-27 11:24 UTC-0300 ~ Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> > >>> Em Wed, Nov 27, 2019 at 03:15:20PM +0100, Jiri Olsa escreveu: > >>>> On Wed, Nov 27, 2019 at 01:38:55PM +0000, Quentin Monnet wrote: > >>>>> 2019-11-27 10:48 UTC+0100 ~ Jiri Olsa <jolsa@xxxxxxxxxx> > >>>>> On the plus side, all build attempts from > >>>>> tools/testing/selftests/bpf/test_bpftool_build.sh pass successfully on > >>>>> my setup with dynamic linking from your branch. > >>>> cool, had no idea there was such test ;-) > >>> Should be the the equivalent to 'make -C tools/perf build-test' :-) > >>> Perhaps we should make tools/testing/selftests/perf/ link to that? > >> It is already run as part of the bpf selftests, so probably no need. > > You mean 'make -C tools/perf build-test' is run from the bpf selftests? > Ah, no, sorry for the confusion. I meant that test_bpftool_build.sh is > run from the bpf selftests. > I am not familiar with perf build-test, but maybe that's something worth > adding to perf selftests indeed. Yeah, I think is worth considering plugging perf's build-test to selftests, if only to expose it to the people that are used with selftests and may start testing perf builds more regularly. - Arnaldo
