On Tue, Apr 2, 2024 at 8:11 AM Tobias Böhm <tobias@xxxxxxxx> wrote: > > Commit 20d59ee55172fdf6 ("libbpf: add bpf_core_cast() macro") added a > bpf_helpers include in bpf_core_read.h as a system include. Usually, the > includes are local, though, like in bpf_tracing.h. This commit adjusts > the include to be local as well. > > Signed-off-by: Tobias Böhm <tobias@xxxxxxxx> > --- > > Sorry for the very wrong first version. > > Changes to v1: > - The patch was based on the libbpf repo instead of the kernel repo. > - The description referred to the commit of the wrong repo. > > tools/lib/bpf/bpf_core_read.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/bpf_core_read.h b/tools/lib/bpf/bpf_core_read.h > index 1ce738d91..b5c7ce5c2 100644 > --- a/tools/lib/bpf/bpf_core_read.h > +++ b/tools/lib/bpf/bpf_core_read.h > @@ -2,7 +2,7 @@ > #ifndef __BPF_CORE_READ_H__ > #define __BPF_CORE_READ_H__ > > -#include <bpf/bpf_helpers.h> > +#include "bpf_helpers.h" > Makes sense, I'll apply the patch. But I wanted to check if this is causing real issues in practice. Mostly to understand if I need 1.4.1 release with this fix? > /* > * enum bpf_field_info_kind is passed as a second argument into > > base-commit: 026e680b0a08a62b1d948e5a8ca78700bfac0e6e > -- > 2.44.0 > >