Hi, Thank you for the review. I have refactored the error messages. I have removed a few more parantheses. On Wednesday, March 27, 2024 6:44:52 AM IST Quentin Monnet wrote: > [...] > We're already on an error path, I'd maybe drop the check on the return > value from rmdir(). It doesn't matter much if it fails, I think. I was thinking that if we fail to mount but manage to create the dir successfully, then we should also clean up that new dir and send a notification if we fail to remove that dir so the user can manually remove it. I guess it's ok to remove that error message though since dealing with the "fail to mount" error will anyway require manual intervention. > [...] > This function must be renamed, as you did at the call sites. Sorry, I must have forgotten to copy this when copying the changes from the bpftool repo to my local bpf-next tree. Thanks, Sahil
