Re: [PATCH bpf-next v2] selftests/bpf: Enable cross platform testing for local vmtest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gather this to riscv64 patchset [0] for better regression:

Link: https://lore.kernel.org/bpf/20240328124916.293173-1-pulehui@xxxxxxxxxxxxxxx/ [0]

On 2024/3/26 23:57, Pu Lehui wrote:
From: Pu Lehui <pulehui@xxxxxxxxxx>

The variable $ARCH in the current script is platform semantics, not
kernel semantics. Rename it to $PLATFORM so that we can easily use $ARCH
in cross-compilation. For now, Using PLATFORM= and CROSS_COMPILE=
options will enable cross platform testing:

   PLATFORM=<platform> CROSS_COMPILE=<toolchain> vmtest.sh -- ./test_progs

Meanwhile, some descriptions have been corrected.

Signed-off-by: Pu Lehui <pulehui@xxxxxxxxxx>
---
v2:
- Specifies the -cpu for the ARM64.
- Completely renamed ARCH to PLATFORM.

  tools/testing/selftests/bpf/vmtest.sh | 40 +++++++++++++++++++--------
  1 file changed, 28 insertions(+), 12 deletions(-)

diff --git a/tools/testing/selftests/bpf/vmtest.sh b/tools/testing/selftests/bpf/vmtest.sh
index 65d14f3bbe30..825149a905e5 100755
--- a/tools/testing/selftests/bpf/vmtest.sh
+++ b/tools/testing/selftests/bpf/vmtest.sh
@@ -4,28 +4,34 @@
  set -u
  set -e
-# This script currently only works for x86_64 and s390x, as
-# it is based on the VM image used by the BPF CI, which is
+# This script currently only works for the following platforms,
+# as it is based on the VM image used by the BPF CI, which is
  # available only for these architectures.
-ARCH="$(uname -m)"
-case "${ARCH}" in
+PLATFORM="${PLATFORM:-$(uname -m)}"
+case "${PLATFORM}" in
  s390x)
  	QEMU_BINARY=qemu-system-s390x
  	QEMU_CONSOLE="ttyS1"
-	QEMU_FLAGS=(-smp 2)
+	HOST_FLAGS=(-smp 2 -enable-kvm)
+	CROSS_FLAGS=(-smp 2)
  	BZIMAGE="arch/s390/boot/vmlinux"
+	ARCH="s390"
  	;;
  x86_64)
  	QEMU_BINARY=qemu-system-x86_64
  	QEMU_CONSOLE="ttyS0,115200"
-	QEMU_FLAGS=(-cpu host -smp 8)
+	HOST_FLAGS=(-cpu host -enable-kvm -smp 8)
+	CROSS_FLAGS=(-smp 8)
  	BZIMAGE="arch/x86/boot/bzImage"
+	ARCH="x86"
  	;;
  aarch64)
  	QEMU_BINARY=qemu-system-aarch64
  	QEMU_CONSOLE="ttyAMA0,115200"
-	QEMU_FLAGS=(-M virt,gic-version=3 -cpu host -smp 8)
+	HOST_FLAGS=(-M virt,gic-version=3 -cpu host -enable-kvm -smp 8)
+	CROSS_FLAGS=(-M virt,gic-version=3 -cpu cortex-a76 -smp 8)
  	BZIMAGE="arch/arm64/boot/Image"
+	ARCH="arm64"
  	;;
  *)
  	echo "Unsupported architecture"
@@ -38,7 +44,7 @@ ROOTFS_IMAGE="root.img"
  OUTPUT_DIR="$HOME/.bpf_selftests"
  KCONFIG_REL_PATHS=("tools/testing/selftests/bpf/config"
  	"tools/testing/selftests/bpf/config.vm"
-	"tools/testing/selftests/bpf/config.${ARCH}")
+	"tools/testing/selftests/bpf/config.${PLATFORM}")
  INDEX_URL="https://raw.githubusercontent.com/libbpf/ci/master/INDEX";
  NUM_COMPILE_JOBS="$(nproc)"
  LOG_FILE_BASE="$(date +"bpf_selftests.%Y-%m-%d_%H-%M-%S")"
@@ -58,6 +64,10 @@ tools/testing/selftests/bpf. e.g:
  If no command is specified and a debug shell (-s) is not requested,
  "${DEFAULT_COMMAND}" will be run by default.
+Using PLATFORM= and CROSS_COMPILE= options will enable cross platform testing:
+
+  PLATFORM=<platform> CROSS_COMPILE=<toolchain> $0 -- ./test_progs -t test_lsm
+
  If you build your kernel using KBUILD_OUTPUT= or O= options, these
  can be passed as environment variables to the script:
@@ -109,7 +119,7 @@ newest_rootfs_version()
  {
  	{
  	for file in "${!URLS[@]}"; do
-		if [[ $file =~ ^"${ARCH}"/libbpf-vmtest-rootfs-(.*)\.tar\.zst$ ]]; then
+		if [[ $file =~ ^"${PLATFORM}"/libbpf-vmtest-rootfs-(.*)\.tar\.zst$ ]]; then
  			echo "${BASH_REMATCH[1]}"
  		fi
  	done
@@ -126,7 +136,7 @@ download_rootfs()
  		exit 1
  	fi
- download "${ARCH}/libbpf-vmtest-rootfs-$rootfsversion.tar.zst" |
+	download "${PLATFORM}/libbpf-vmtest-rootfs-$rootfsversion.tar.zst" |
  		zstd -d | sudo tar -C "$dir" -x
  }
@@ -244,12 +254,17 @@ EOF
  		exit 1
  	fi
+ if [[ "${CROSS_COMPILE}" != "" ]]; then
+		QEMU_FLAGS=("${CROSS_FLAGS[@]}")
+	else
+		QEMU_FLAGS=("${HOST_FLAGS[@]}")
+	fi
+
  	${QEMU_BINARY} \
  		-nodefaults \
  		-display none \
  		-serial mon:stdio \
  		"${QEMU_FLAGS[@]}" \
-		-enable-kvm \
  		-m 4G \
  		-drive file="${rootfs_img}",format=raw,index=1,media=disk,if=virtio,cache=none \
  		-kernel "${kernel_bzimage}" \
@@ -384,7 +399,8 @@ main()
  	fi
local kconfig_file="${OUTPUT_DIR}/latest.config"
-	local make_command="make -j ${NUM_COMPILE_JOBS} KCONFIG_CONFIG=${kconfig_file}"
+	local make_command="make ARCH=${ARCH} CROSS_COMPILE=${CROSS_COMPILE} \
+			    -j ${NUM_COMPILE_JOBS} KCONFIG_CONFIG=${kconfig_file}"
# Figure out where the kernel is being built.
  	# O takes precedence over KBUILD_OUTPUT.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux