On Tue, Mar 26, 2024 at 12:24 AM Magnus Karlsson <magnus.karlsson@xxxxxxxxx> wrote: > > On Thu, 21 Mar 2024 at 15:05, Tushar Vyavahare > <tushar.vyavahare@xxxxxxxxx> wrote: > > > > Please find enclosed a patch set that introduces enhancements and new test > > cases to the selftests/xsk framework. These test the robustness and > > reliability of AF_XDP across both minimal and maximal ring size > > configurations. > > > > While running these tests, a bug [1] was identified when the batch size is > > roughly the same as the NIC ring size. This has now been addressed by > > Maciej's fix. > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=913eda2b08cc49d31f382579e2be34c2709eb789 > > > > Patch Summary: > > > > 1. This commit syncs the ethtool.h header file between the kernel source > > tree and the tools directory to maintain consistency. > > > > 2: Modifies the BATCH_SIZE from a constant to a variable, batch_size, to > > support dynamic modification at runtime for testing different hardware > > ring sizes. > > > > 3: Implements a function, get_hw_ring_size, to retrieve the current > > maximum interface size and store this information in the > > ethtool_ringparam structure. > > > > 4: Implements a new function, set_hw_ring_size, which allows for the > > dynamic configuration of the ring size within an interface. > > > > 5: Introduce a new function, set_ring_size(), to manage asynchronous AF_XDP > > socket closure. Make sure to retry the set_hw_ring_size function > > multiple times, up to SOCK_RECONF_CTR, if it fails due to an active > > AF_XDP socket. Immediately return an error for non-EBUSY errors. > > > > 6: Adds a new test case that puts the AF_XDP driver under stress by > > configuring minimal hardware and software ring sizes, verifying its > > functionality under constrained conditions. > > > > 7: Add a new test case that evaluates the maximum ring sizes for AF_XDP, > > ensuring its reliability under maximum ring utilization. > > > > Testing Strategy: > > > > Check the system in extreme scenarios, such as maximum and minimum > > configurations. This helps identify and fix any bugs that may occur. > > Thanks Tushar for this patch set. A year and a half ago, we had some > bugs in this area in the ice driver, so these new tests are very > welcome. > > Acked-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> Agree, but CI doesn't like the set. Tushar, pls keep the Ack when you respin.
