Andrii Nakryiko wrote:
> On Mon, Nov 25, 2019 at 12:36 PM John Fastabend
> <john.fastabend@xxxxxxxxx> wrote:
> >
> > Andrii Nakryiko wrote:
> > > To fix build with !CONFIG_MMU, implement it for no-MMU configurations as well.
> > >
> > > Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> > > Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
> > > Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> > > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
> > > ---
> > > mm/nommu.c | 15 +++++++++++++--
> > > 1 file changed, 13 insertions(+), 2 deletions(-)
> > >
[...]
> > Hi Andrii, my first reaction was that it seemed not ideal to just ignore
> > the node value like this but everything I came up with was uglier. I
> > guess only user is BPF at the moment so it should be fine.
>
> Yeah, but that's what other node-aware vmalloc() variants do in
> nommu.c, so at least it's consistent with other cases. Thanks for
> review!
Great, at least folks (not me) who are used to working with no-mmu APIs
will expect this then.
>
> >
> > Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>
