Hi Yonghong, kernel test robot noticed the following build errors: [auto build test ERROR on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Yonghong-Song/bpf-Add-bpf_link-support-for-sk_msg-and-sk_skb-progs/20240320-015917 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20240319175406.2940628-1-yonghong.song%40linux.dev patch subject: [PATCH bpf-next v2 1/6] bpf: Add bpf_link support for sk_msg and sk_skb progs config: nios2-randconfig-001-20240321 (https://download.01.org/0day-ci/archive/20240322/202403220545.KEzjr9hI-lkp@xxxxxxxxx/config) compiler: nios2-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240322/202403220545.KEzjr9hI-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202403220545.KEzjr9hI-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): net/core/skmsg.c: In function 'bpf_sk_msg_skb_link_release': >> net/core/skmsg.c:1279:23: error: implicit declaration of function 'sock_map_prog_update' [-Werror=implicit-function-declaration] 1279 | (void)sock_map_prog_update(sk_link->map, NULL, link->prog, | ^~~~~~~~~~~~~~~~~~~~ >> net/core/skmsg.c:1281:17: error: implicit declaration of function 'bpf_map_put_with_uref' [-Werror=implicit-function-declaration] 1281 | bpf_map_put_with_uref(sk_link->map); | ^~~~~~~~~~~~~~~~~~~~~ net/core/skmsg.c: At top level: >> net/core/skmsg.c:1371:5: warning: no previous prototype for 'bpf_sk_msg_skb_link_create' [-Wmissing-prototypes] 1371 | int bpf_sk_msg_skb_link_create(const union bpf_attr *attr, struct bpf_prog *prog) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ net/core/skmsg.c: In function 'bpf_sk_msg_skb_link_create': >> net/core/skmsg.c:1383:15: error: implicit declaration of function 'bpf_map_get_with_uref' [-Werror=implicit-function-declaration] 1383 | map = bpf_map_get_with_uref(attr->link_create.target_fd); | ^~~~~~~~~~~~~~~~~~~~~ >> net/core/skmsg.c:1383:13: warning: assignment to 'struct bpf_map *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1383 | map = bpf_map_get_with_uref(attr->link_create.target_fd); | ^ cc1: some warnings being treated as errors vim +/sock_map_prog_update +1279 net/core/skmsg.c 1272 1273 static void bpf_sk_msg_skb_link_release(struct bpf_link *link) 1274 { 1275 struct bpf_sk_msg_skb_link *sk_link = bpf_sk_msg_skb_link(link); 1276 1277 mutex_lock(&link_mutex); 1278 if (sk_link->map) { > 1279 (void)sock_map_prog_update(sk_link->map, NULL, link->prog, 1280 sk_link->attach_type); > 1281 bpf_map_put_with_uref(sk_link->map); 1282 sk_link->map = NULL; 1283 } 1284 mutex_unlock(&link_mutex); 1285 } 1286 1287 static int bpf_sk_msg_skb_link_detach(struct bpf_link *link) 1288 { 1289 bpf_sk_msg_skb_link_release(link); 1290 return 0; 1291 } 1292 1293 static void bpf_sk_msg_skb_link_dealloc(struct bpf_link *link) 1294 { 1295 kfree(bpf_sk_msg_skb_link(link)); 1296 } 1297 1298 static int bpf_sk_msg_skb_link_update_prog(struct bpf_link *link, 1299 struct bpf_prog *new_prog, 1300 struct bpf_prog *old_prog) 1301 { 1302 const struct bpf_sk_msg_skb_link *sk_link = bpf_sk_msg_skb_link(link); 1303 int ret = 0; 1304 1305 mutex_lock(&link_mutex); 1306 if (old_prog && link->prog != old_prog) { 1307 ret = -EPERM; 1308 goto out; 1309 } 1310 1311 if (link->prog->type != new_prog->type) { 1312 ret = -EINVAL; 1313 goto out; 1314 } 1315 1316 ret = sock_map_prog_update(sk_link->map, new_prog, old_prog, 1317 sk_link->attach_type); 1318 if (!ret) 1319 bpf_prog_inc(new_prog); 1320 1321 out: 1322 mutex_unlock(&link_mutex); 1323 return ret; 1324 } 1325 1326 static int bpf_sk_msg_skb_link_fill_info(const struct bpf_link *link, 1327 struct bpf_link_info *info) 1328 { 1329 const struct bpf_sk_msg_skb_link *sk_link = bpf_sk_msg_skb_link(link); 1330 u32 map_id = 0; 1331 1332 mutex_lock(&link_mutex); 1333 if (sk_link->map) 1334 map_id = sk_link->map->id; 1335 mutex_unlock(&link_mutex); 1336 1337 if (link->type == BPF_LINK_TYPE_SK_MSG) { 1338 info->skmsg.map_id = map_id; 1339 info->skmsg.attach_type = sk_link->attach_type; 1340 } else { 1341 info->skskb.map_id = map_id; 1342 info->skskb.attach_type = sk_link->attach_type; 1343 } 1344 return 0; 1345 } 1346 1347 static void bpf_sk_msg_skb_link_show_fdinfo(const struct bpf_link *link, 1348 struct seq_file *seq) 1349 { 1350 const struct bpf_sk_msg_skb_link *sk_link = bpf_sk_msg_skb_link(link); 1351 u32 map_id = 0; 1352 1353 mutex_lock(&link_mutex); 1354 if (sk_link->map) 1355 map_id = sk_link->map->id; 1356 mutex_unlock(&link_mutex); 1357 1358 seq_printf(seq, "map_id:\t%u\n", map_id); 1359 seq_printf(seq, "attach_type:\t%u (...)\n", sk_link->attach_type); 1360 } 1361 1362 static const struct bpf_link_ops bpf_sk_msg_skb_link_ops = { 1363 .release = bpf_sk_msg_skb_link_release, 1364 .dealloc = bpf_sk_msg_skb_link_dealloc, 1365 .detach = bpf_sk_msg_skb_link_detach, 1366 .update_prog = bpf_sk_msg_skb_link_update_prog, 1367 .fill_link_info = bpf_sk_msg_skb_link_fill_info, 1368 .show_fdinfo = bpf_sk_msg_skb_link_show_fdinfo, 1369 }; 1370 > 1371 int bpf_sk_msg_skb_link_create(const union bpf_attr *attr, struct bpf_prog *prog) 1372 { 1373 struct bpf_link_primer link_primer; 1374 struct bpf_sk_msg_skb_link *sk_link; 1375 enum bpf_attach_type attach_type; 1376 enum bpf_link_type link_type; 1377 struct bpf_map *map; 1378 int ret; 1379 1380 if (attr->link_create.flags) 1381 return -EINVAL; 1382 > 1383 map = bpf_map_get_with_uref(attr->link_create.target_fd); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
