On 3/19/2024 12:46 PM, Martin KaFai Lau wrote: > On 3/18/24 12:02 PM, Abhishek Chauhan (ABC) wrote: >>>>>>> I think the "struct inet_frag_queue" also needs a new "user_delivery_time" >>>>>>> field. "mono_delivery_time" is already in there. >>>> [ ... ] >>>> >> Martin, Do we really need to add user_delivery_time as part of inet_frag_queue struct? I was wondering why is this required since we are using tstamp_type:2 to >> distinguish between timestamp anyway . > > > The context for this was before combining mono_delivery_time:1 and user_delivery_time:1 into tstamp_type:2. No need to add user_delivery_time to inet_frag_queue because it is combined into tstamp_type:2. If mono_delivery_time:1 is replaced with tstamp_type:2 in sk_buff, the same should be done in inet_frag_queue. > Thats what i was planning to do. This is more or like the patch 3 - when brings in the changes of two bits. Thanks Martin for clarification. >
