2024-03-14 21:16 UTC+0000 ~ Sahil <icegambit91@xxxxxxxxx> > Hi, > > On Wednesday, March 13, 2024 9:17:44 PM IST Quentin Monnet wrote: >> Thanks! Apologies for the delay. > > No worries! Thank you for the review. > >> [...] >> Note: you don't need the blank lines between the tags. >> [...] >> You can keep the changelog as part of the patch description. > > Got it. I'll keep this in mind when I submit v3. > >> [...] >> With all the checks and the potential directory creation, we could maybe >> rename this into "prepare_bpffs_dir()" or something like this? > > "prepare_bpffs_dir" is quite apt. If longer names are acceptable then I > would also recommend "prepare_and_mount_bpffs_dir" so it indicates > that it'll also mount the bpffs on the dir (when relevant) after performing > the checks. The length looks acceptable to me. I used "prepare" to summarise "create and mount", if you prefer "mount" explicitly then maybe "create_and_mount_bpffs_dir()"? There's no other preparation step as far as I remember so we should as well make it clear. > That's really nice to hear. I'll incorporate the recommended changes and > will send v3 soon. Thanks a lot, Quentin
